modify method exceptions are not catched

Hi,

Exceptions in modify method are not catched by .catch

knex.select()
    .from('Account')
    .modify(function(qb) {
        throw new Error('ERROR HERE');
    })
    .then(r => {})
    .catch(err => console.log('Catched Error:', err));

// Throws: ERROR HERE

On the other hand

knex.select()
    .from('Account')
    .where(function() {
        throw new Error('ERROR HERE');
    })
    .then(r => {})
    .catch(err => console.log('Catched Error:', err));

// Throws: Catched Error: ERROR HERE

Regards,

[johanneslumpe]

@elhigu Your second version could be even nicer by just using Promise.try (when using bluebird):

return Promise
  .try(() => (
    knex
      .select()
      .from('some_table')
      .where('Address.organizationId', 1)
      .modify(rqlToKnex, rql)
  ))
  .then(r => reply({ result: r }))
  .catch(err => reply(err));  

[ozum]

@elhigu, I mean, I could not find a workaround without adding further nested code, otherwise second workaround is totally acceptable, and I already applied second one in a couple of places. However for another larger project I have, I wish I had small number of modify methods.

@johanneslumpe, also nice suggestions.

Thanks both of you guys for your helps and suggestions.