pool: connection ending in fatal error are not removed from the generic pool

when having a fatal error on a mysql connection using knex 0.6.22 & pool & mysql driver, the connection is not removed from the pool.

Further requests using this connection end in mysql driver error “cannot enqueue … after fatal error” (PROTOCOL_ENQUEUE_AFTER_FATAL_ERROR)

a workaround :

var knex;

var connectionErrorHandler = function (connection, err) {
  if (connection && err && err.fatal) {
    if (connection.removedFromThePool)
      return;
    connection.removedFromThePool = true;
    knex.client.pool.genericPool.destroy(connection);
  }
};

var config =  {
  client: 'mysql',
  (...)
  pool: {
    (...)
    afterCreate: function (connection, callback) {
      connection.on('error', connectionErrorHandler.bind(null, connection));
      connection.on('end', connectionErrorHandler.bind(null, connection));
      callback();
    }
  }
};

knex = knexInit(config);

it might be linked to #206

[elhigu]

@shwuhk I would recommend to not use 0.14 until 0.14.1 is released. There are couple of nasty issues which were missed when generic-pool was updated. I’m working on those and hope to get 0.14.1 out this week.

[elhigu]

@shwuhk 0.14.1 it is out