Strange "Undefined binding(s) detected" error message

Environment

Knex version: 0.20.10 Database + version: Postgres 12

Bug

1. Explain what kind of behaviour you are getting and how you think it should do

knex.raw("?", [
  knex.insert({ id: "b", fields: { a: undefined } }).into("test"),
])

1. Error message

Error: Undefined binding(s) detected for keys [] when compiling RAW query: insert into "test" ("fields", "id") values (?, ?)

This error message is puzzling. Undefined keys are not printed.

[genadis]

I believe this https://github.com/knex/knex/issues/3548 is related

[kibertoad]

@thekuom It’s less straightforward than I though, due to rather cluttered logic around this place, and a peculiar way raw insert is being done in original case. If you have some time to dig deeper, here’s a test case you can use for reproducing the issue:

const Knex = require('../../../lib/index');
const { expect } = require('chai');

describe('querybuilder', () => {
  let knex;
  beforeEach(() => {
      knex = Knex({
        client: 'sqlite',
        connection: ':memory:',
      });
    },
  );

  it('should throw an informative error on undefined binding', async () => {
    try {
      await knex.raw('?', [
        knex.insert({ id: 'b', fields: { a: undefined } }).into('test'),
      ]);
    } catch (err) {
      expect(err.message).eql('Undefined binding(s) detected for keys [0] when compiling RAW query: insert into `test` (`fields`, `id`) values (?, ?)');
    }
  });
});

@leventov For curiosity sake, why you building query in a such complex way?

Both of these should already work properly:

knex.raw('?', [undefined])

or

knex.raw(':field', { field: undefined })

Does your query work correctly when value is not undefined?