Using nested transactions with save points

Environment

Knex version: 0.19.1 Database + version: PostgreSQL 11 OS: MacOS Mojave

Bug

I am trying to use nested transactions with save points and it doesn’t seems to be working with promises API.

Here’s some code (I am sharing the minimum required code to reproduce the problem)

Following doesn’t work

async function run () {
  const trx = await knex.transaction()
  const trx2 = await trx.transaction()
  console.log('never reached here')
}

Following works

function runWithCallbacks () {
  knex.transaction((trx) => {
   trx.transaction((trx2) => {
    console.log('reached here>')
   })
 })
}

The first example doesn’t work since the promise doesn’t resolve unless trx2 commit/rollback and it cannot, since the code never moves to the next line.

Is this the intended behavior?

[kibertoad]

@thetutlage Released in 0.19.2

[thetutlage]

Found one regression here. Now, since we are faking the container, the rejection behavior of rollback is to always reject.

As a solution, I believe we can set doNotRejectOnRollback when it’s not explicitly defined when starting a nested transaction.

if (!options) {
	options = { doNotRejectOnRollback: true }
} else if (isUndefined(options.doNotRejectOnRollback)) {
	options.doNotRejectOnRollback = true
}

// The existing code
return new Promise((resolve, _reject) => {
	trxClient.transaction(
  	(nestedTrx) => {
    	resolve(nestedTrx);
  	},
  	options,
  	trx
	);
});