bitstamp v2 API should be taking UUID nonces

It appears that methods that call the Bitstamp v2 api are sending Long nonces rather than UUID nonces. This breaks with a nonce error much of the time.

Some background: I just upgraded some code that fetches balances from Bitstamp to xchange 5.0.6, which includes a change to use the v2 API for fetching balances: https://github.com/knowm/XChange/commit/dd134e31dd50663b30bb61ae19150e7b6d387e0f

Shortly after the change, we started getting 403’s with an “Invalid nonce” message. I’ve taken a (newbie, not-too-detailed) look at your code, and it looks like the nonce generation algorithm used for Bitstamp’s v2 api still relies on sending a Long nonce, rather than a UUID.

Falling back to xchange 5.0.4 immediately fixed this error.

[mathvdh]

Hi @joakjo , Yes I was seeing that we are actually sending form params instead of headers … I’m working on it … Thanks

[earce]

@joakjo that’s interesting because some of the API endpoint present in v1 I do not see in v2.

@mathvdh I can give you some guidance.

In bitstamp exchange you will probably want to add a second nonceFactory

  private final SynchronizedValueFactory<String> uuidNonceFactory = 
          () -> UUID.randomUUID().toString();

You will probably need to pass it into BitstampTradeService & BitstampAccountService so you can use it there.

Then in bitstampauthenticatedv2 you will need to change the nonce param from <Long> to <String>

See how far this gets you