[FTX] No implementation of cancelOrder for a sub-account

There is no possibility to cancel an order if you are using a sub-account in the current implementation.

The only cancelOrder function is :

@Override  
public boolean cancelOrder(String orderId) throws IOException { 
   return cancelFtxOrder(orderId);  
}

There is no cancelOrderForSubaccount version like there is for example :

placeLimitOrder(LimitOrder limitOrder)

and

placeLimitOrderForSubaccount(String subaccount, LimitOrder limitOrder)

I’m not sure if it’s THE way to go to have a version of every function with a postfix of ForSubaccount but it does work so I propose to add a cancelOrderForSubaccount version.

If nobody disagrees I will submit a PR.

[imTigger]

The getTradeHistory, getOpenOrders and getOpenPositions are missing too.

When I hacking the code, I come up with an idea: Instead of implementing every *ForSubaccount method, will it be a good idea to just use exchange.getExchangeSpecification().getUserName() as subaccount parameter?

Then we just need to pass exSpec.setUserName("some-subaccount") to ExchangeSpecification when creating the exchange, and subsequence calls to all services will use that as subaccount. If it’s not specified it naturally null, which works as before.

I am new to this project, don’t know if this will break any other things.

[mathvdh]

We can close this issue as it’s resolved in the PR above