new hitbtc api question

@timmolter @EricAnderson1000

I just noticed the deletion of the old hitbtc implemention. Are we sure the new one is ready to go? At a glance I just noticed the code for getFundingHistory:

  @Override
  public List<FundingRecord> getFundingHistory(TradeHistoryParams params) throws IOException {

    List<HitbtcTransaction> transactions = getTransactions();

    List<FundingRecord> records = new ArrayList<>();
    for (HitbtcTransaction transaction : transactions) {
      records.add(HitbtcAdapters.adapt(transaction));
    }
    return records;
  }

This doesn’t look right to me, it calls getTransactions and converts all responses into FundingRecords, is this correct? Surely not every transaction can be assumed to be a FundingRecord.

[EricAnderson1000]

@npomfret @timmolter Here is a PR https://github.com/timmolter/XChange/pull/2001

Please give me feedback Note: hitbtc just returns a list of the results. So no total is provided. You basically have to blind page results.

[EricAnderson1000]

Sorry it’s been a busy week with Christmas coming up. I’ll look into fixing this method this morning.

I believe this method was a copy over method. I’ll take a look.