Multiple next with non async function

Hi,

I wrote test like below, it throw an error but it come like this

UnhandledPromiseRejectionWarning: Error: next() called multiple times

and the test failed. Is this expected?

  it(`should throw if next() is called multiple times in non async function`, async () => {
    const stack = [];

    stack.push((ctx, next) => {
      next();
      next();
    });

    expect.hasAssertions();

    try {
      await compose(stack)({});
    } catch (error) {
      expect(error).toBeInstanceOf(Error);
    }
  });

[Runrioter]

No, koa-compose support sync calls. The problem here is next() return a Promise. We need return Promise or include it in async function (had been included in test case).

The following one is use promise-based sync function.

  it(`should throw if next() is called multiple times in non async function`, () => {
    const stack = [];

    stack.push((ctx, next) => {
      return next().then(() => {
        return next()
      });
    });

    return compose(stack)({}).then(() => {
      throw new Error('boom')
    }, (err) => {
      assert(/multiple times/.test(err.message))
    })
  });

[fl0w]

@Runrioter that’s exactly what I ment (I maybe expressed it badly). If you’re dealing with them as promises the request chain isn’t synchronous, the execute on a new tick.