Response is not getting compressed or being corrupted?

this is my middleware code

app.use(compress({ filter: function (content_type) { return /text/i.test(content_type) }, threshold: 1, flush: require('zlib').Z_SYNC_FLUSH }))

And this is my response code

ctx.body = 'Hello world'
ctx.compress = true
ctx.set('Content-Type', 'text/plain')
ctx.set('content-encoding', 'gzip')

now when I hit the url localhost:3000/test, I get the error saying

ERR_CONTENT_DECODING_FAILED

But when I hit same url using CURL, I get the text saying

Hello World

I guess it’s apparent that data is not getting compressed otherwise curl wouldn’t have shown plain text. And I think Chrome error is due to content-encoding being gzip but actual data being plain text. May be I’m wrong but this is sure that there is some problem is my code otherwise chrome should have shown Hello World without error, isn’t?

[ashishnetworks]

Thank you @jonathanong for your comments. I just retested the whole process once again and I realised that my code was already working. I was making mistakes in assuming that response should always be compressed. But what I realised now, after lots of research is that compression works only when the client sends a header with Accept-Encoding. If supported Accept-Encoding is gzip, the response will be compressed in gzip if it’s deflate, the response shall be compressed in deflate form, and if it’s not mentioned response shall be simple plain data. I was receiving plain text in curl because curl does not send Accept-Encoding in its default request, but when I sent curl request using curl -H 'Accept-Encoding: gzip' -D - http://localhost:3000 my response was coded into compressed form. So my code has been working for always. Thanks

Edit: And you were also right that if content-encoding is set, module will not run so we don’t have to explicitly set the content-encoding, it should be set by compression middleware depending on Accept-Encoding of the request

[jonathanong]

pull request