need your help for hot-reloading server with webpack

Hi everyone!

After reading the article Hot reload all the things! I’ve created a simple koa-hot-reloading-server.

Unfortunately it doesn’t work while changes are recompile. original server based on express works fine express-hot-reloading-server

the main thing is in this code:

import http from 'http'
import app from './server'

const server = http.createServer(app)
let currentApp = app
server.listen(3000)

if (module.hot) {
 module.hot.accept('./server', () => {
  server.removeListener('request', currentApp)
  server.on('request', app)
  currentApp = app
 })
}

I’ve translated it into koa:

import http from 'http';
import app from './server';

const port = 3000;

const appCallback = app.callback();
const server = http.createServer(appCallback);

let currentApp = appCallback;

server.listen(port);

if (module.hot) {
    module.hot.accept('./server', () => {
        server.removeListener('request', currentApp);
        server.on('request', appCallback);
        currentApp = appCallback;
    });
}

console.log(`Server running on: http://localhost: ${port}`);

it serves requests but doesnt reload servers new code, e.g. these lines are not have an action

        server.removeListener('request', currentApp);
        server.on('request', appCallback);
        currentApp = appCallback;

Help me please

[bttmly]

You need to call app.callback() upon module.hot.accept. A difference between Koa and Express is that express “instances” are actually functions (which can be passed to http.createServer directly) with extra properties on them, whereas new Koa() returns an object, with a method (called callback) which returns a function for use with http.createServer.

This should work:

import http from 'http';
import app from './server';

const port = 3000;

let currentApp = app.callback();
const server = http.createServer(currentApp);

server.listen(port);

if (module.hot) {
    module.hot.accept('./server', () => {
        server.removeListener('request', currentApp);
        currentApp = app.callback();
        server.on('request', currentApp);
    });
}

console.log(`Server running on: http://localhost: ${port}`);

[sibelius]

@jonathanong does node-dev works well with babel 7?