question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

test against the http2 compatibility layer

See original GitHub issue

although we don’t support the new HTTP2 APIs, we should run all our tests against both the http and http2 modules, using only the HTTP/1 API

easiest method would be to set an env var like KOA_TEST_HTTP_MODULE=http and run tests with each option.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
ognjenjevremoviccommented, Apr 22, 2021

Hey @jkomyno, apologize for my late response. I didn’t have much success with this (as far as I remember). I can’t remember why, but I think it was something regarding on how I approached the issue altogether.

I think I tried merging the files at first, with both tests included (and reading through the command line arguments, when starting the tests to determine which set of tests to run). I guess the tests should have been separated into different directories / files. I might give this another short, next week (this time, posting the status update on time).

If you wanted to give this issue a shot instead, please do feel free to do so as I’m not actively working on it.

1reaction
miwnwskicommented, Mar 2, 2021

Hi @ognjenjevremovic,

This issue is open for grabs. My personal suggestion is that if you want to make a contributing PR just go for it. It’ll get reviewed once pushed.

To get started with HTTP/2 tests I suggest taking a look at available test and mimic these using http2 instead. Contrary to HTTP/1 which is automatically selected when calling Koa#listen you would need to call Koa#callback to get a function that quacks like a requestListener and do some tests against node.js’s http2 built-in module.

Read more comments on GitHub >

github_iconTop Results From Across the Web

HTTP/2 Test - Verify HTTP/2 Support - KeyCDN Tools
This test can check HTTP and HTTPS but most browsers only support HTTP/2 for HTTPS, which means you must migrate to HTTPS if...
Read more >
The differences between http2 compatibility API and http[s]
But, some http2 compatibility API still behaves differently and lacks some APIs from http[s] and it causes breakages to ecosystems for http[s] ( ......
Read more >
HTTP/2 Frequently Asked Questions
Why the rules around Continuation on HEADERS frames? ... In other words, the HTTP version only indicates wire compatibility, not feature sets or...
Read more >
Introduction to HTTP 2. A Brief History Of HTTP - Medium
HTTP/2 is backwards compatible, browsers that do not support HTTP/2 will fallback to using HTTP/1.1. we will test backward compatibility with curl request....
Read more >
HTTP/2 guide - Apache HTTP Server Version 2.4
HTTP/2 is the evolution of the world's most successful application layer protocol, HTTP. It focuses on making more efficient use of network resources....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found