Multiple routes are executed

There is an open bug in the original koa-router repository which I can still reproduce: https://github.com/ZijianHe/koa-router/issues/231

I think this behaviour makes sense in a way, but is there any solution to set routes to be “exclusive”?

Code sample

const Koa = require('koa');
const Router = require('@koa/router');

const app = new Koa();
const router = new Router();

router.get('/users/all', (ctx, next) => {
  console.log('route 1');
  ctx.body = 'route 1';
  next();
});

router.get('/users/:id(.*)', (ctx, next) => {
  console.log('route 2');
  ctx.body = 'route 2';
  next();
});

app.use((ctx, next) => {
  console.log(ctx.request.method, ctx.request.url, 'START');
  next();
});

app
  .use(router.routes())
  .use(router.allowedMethods());

app.use((ctx, next) => {
  console.log(ctx.request.method, ctx.request.url, 'END');
  next();
});

app.listen(3333);

Expected Behaviour

$ node app
GET /users/all START
route 1
GET /users/all END

Actual Behaviour

$ node app
GET /users/all START
route 1
route 2
GET /users/all END

Versions

@koa/router: 9.1.0
koa: 2.13.0
node: 12.13.1
npm: 6.12.1

[dsmackie]

Old issue but a solution is to enforce the requirement for the second route to be a number.

Changing the match path to '/users/:id(\\d+)' will ensure that it will only match if the :id is of type decimal.

[sichatur]

Hi @dios-david, were you able to find a workaround for this? I am facing the same issue. Don’t know if it’s a feature or a bug at this point.