Router.use() doesn't take in composed Router middleware as expected

It’s just a quick mirror of https://github.com/ZijianHe/koa-router/issues/454, which is unresolved but closed.

node.js version: 10.16.0

npm/yarn and version: yarn 1.17.3

@koa/router version: 8.0.6

koa version: 2.11.0

koa-compose version: 4.1.0

Code sample:

const app = new Koa();
const router1 = new Router();
const router2 = new Router();

router2.get('/', ctx => {
  ctx.body = 'not work';
});

router1.use('/', compose([router2.routes(), router2.allowedMethods()]));

app.use(router1.routes()).use(router1.allowedMethods());

Expected Behavior:

Visit '/', get 'not work'

Actual Behavior:

Visit '/', get 'Not Found'

[lagden]

@meteorlxy

It’s not necessary use compose.
You can see the @dominicegginton example above.

I make this way to put my routes together (using compose):
https://github.com/lagden/api-boilerplate/blob/master/server/routes/index.js

[cmd-johnson]

I got @koa/router to work with koa-compose like this:

const app = new Koa()
const router1 = new Router()
const router2 = new Router()

router2.get('/', ctx => {
  ctx.body = 'this works!'
})
const composed = Object.assign(
  compose([router2.routes(), router2.allowedMethods()]),
  { router: router2 }
)

router1.use('/', composed)
app.use(router1.routes()).use(router1.allowedMethods())

I’m pretty sure middleware.router belongs to the internal API of @koa/router and as such may be changed without notice, but for now this appears to be working perfectly fine.