[FEATURE] scale hyperparameter for the RepeatingBasisFunction

Hi!

How about a hyperparameter that controls the width of the RBFs? You set it to a (sensible) fixed value so far.https://github.com/koaning/scikit-lego/blob/51ef0c7f4fb0ac8717b3660931b78633831e170e/sklego/preprocessing/repeatingbasis.py#L86

But how about some scale hyperparameter and changing this line to

self.width_ = self.scale / self.n_periods

with a default parameter of 1? I think it’s good to have a choice there.

Best Robert

[Garve]

Sure, I would also keep the default like this. It usually works quite well and 1 is a great constant, nobody asks questions 😉

[Garve]

I think @Garve means that the scale_ feature should influence the width of the generated rbf features. Increasing the width would make farther away values in the original space more alike in the transformed space and therefore influence the model fitting.

Adding it makes sense to me, but I understand the confusion with calling it scale.

Oh yeah, I mean scale in the sense of being able to scaling the width of the bumps. Sure, the name can be changed to something else, I just didn’t want to call it width again since there is width_ already. And this shouldn’t change much, there should be just some scaling factor to it.