question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Overlap with sklearn

See original GitHub issue

Hey folks! This looks like a really cool library that I hadn’t seen before. It looks like there’s a couple of things we now have upstream in sklearn and I wanted to note that so you could maybe add that to the docs.

Also, I’d be really curious to see which parts could be upstreamed. Contributing to sklearn can be a bit of a lengthy process, but if some of your tools are generally useful it might be nice to put them into sklearn.

Btw, TrainOnlyTransformerMixin is quite interesting. I was wondering how you do that because the scikit-learn API doesn’t allow it (which I dislike), but it seems you’re hashing and checking for equality? That’s certainly an interesting approach. Ideally I’d like to fix the API so this isn’t as awkward.

I think EstimatorTransformer is the same as the sklearn VotingClassifier, right? Though maybe that’s not super clear from the name?

And you’re probably aware that ColumnSelector + FeatureUnion has finally after a long wait been implemented in ColumnTransformer. So this example is actually significantly shorter in sklearn now: https://scikit-lego.readthedocs.io/en/latest/preprocessing.html#Example-2

Most cases of IdentityTransformer are now handled with the special 'passthrough' string.

I thought RandomRegressor is the same as DummyRegressor but apparently we don’t have a sampling strategy for DummyRegressor. It think that would be a nice addition if you’re interested.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:11 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
amuellercommented, May 28, 2020

The comment on the fairness package for scikit-learn-contrib 😉

1reaction
koaningcommented, May 28, 2020

@amueller one question out of curiosity. How did you find this repo?

Read more comments on GitHub >

github_iconTop Results From Across the Web

sklearn.feature_extraction.image.reconstruct_from_patches_2d
Patches are assumed to overlap and the image is constructed by filling in the patches from left to right, top to bottom, averaging...
Read more >
sklearn decision tree plot_tree nodes are overlapping
When I plot my sklearn decision tree using sklearn.tree.plot_tree() , the nodes are overlapping on the deeper levels and I cannot read what ......
Read more >
StratifiedShuffleSplit generates overlapping train and test ...
StratifiedShuffleSplit generates overlapping train and test indices · Issue #6121 · scikit-learn/scikit-learn · GitHub.
Read more >
skrf.frequency.Frequency.overlap — scikit-rf Documentation
Calculates overlapping frequency between self and f2. See also. overlap_freq. Parameters. f2 (Frequency) –. Return type. Frequency.
Read more >
How to handle overlapping classes - Cross Validated
If overlapping classes means that a single data instances are assigned multiple classes, you basically two options:.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found