Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Error after update

See original GitHub issue

After update:

`"export ‘DeviceDetectorModule’ was not found in ‘ngx-device-detector’

ERROR in src/app/core/core.module.ts:15:10 - error TS2305: Module '"../../../node_modules/ngx-device-detector/ngx-device-detector"' has no exported member 'DeviceDetectorModule'.

15 import { DeviceDetectorModule } from 'ngx-device-detector';`

Issue Analytics

State:
Created 3 years ago
Reactions:16
Comments:19 (1 by maintainers)

Top GitHub Comments

3reactions

AhsanAyazcommented, Aug 27, 2020

@elementalPRESS, @drewpayment, @marlonbaskin, @edwincabrejos, @air-Design, @veenagadag, @MoxxiManagarm , @quosol , @ksrebrev , @ochikov , @madviral , @Ruslancic. The issue has been fixed with the latest release 1.5.2. Please upgrade your dependencies. 🙂 Also, thanks for being awesome. 🎉

Will now release the 2.0.0 without the DeviceDetectorModule. Closing the issue. Feel free to re-open if it persists 🙂

3reactions

marlonbaskincommented, Aug 27, 2020

@AhsanAyaz - I would kindly suggest that you re-version this update to 2.0. Such a major, breaking change really shouldn’t be part of a minor release. Most users wouldn’t expect an update from 1.46 to 1.5 to include breaking changes, if you’re going by the rules of semantic versioning (which is highly encouraged): https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,

MINOR version when you add functionality in a backwards compatible manner, and

PATCH version when you make backwards compatible bug fixes.