sp-pnp-js batch requests failing with 400: Bad Request

Hi,

I am building an Angular 5 application using sp-rest-proxy for local development. I am getting a 400 bad Request when trying to do a batch request using sp-pnp-js.

SharePoint Version : SharePoint Online sp-rest-proxy : latest sp-pnp-js: 3.0.4

const batch = pnp.sp.createBatch();
    array.forEach(element => {
      web.lists.getByTitle('ListName').items(element.Id).inBatch(batch).get()
        .then(data => console.log(data))
        .catch(error => console.log(error));
    });
    batch.execute().then(() => {
      console.log('All is well');
    });

Error:

Error: Error making HttpClient request in queryable: [400] Bad Request
    at new ProcessHttpClientResponseException (exceptions.js:24)
    at eval (core.js:33)
    at ZoneDelegate.invoke (zone.js:388)
    at Object.onInvoke (core.js:4745)
    at ZoneDelegate.invoke (zone.js:387)
    at Zone.run (zone.js:138)
    at eval (zone.js:858)
    at ZoneDelegate.invokeTask (zone.js:421)
    at Object.onInvokeTask (core.js:4736)
    at ZoneDelegate.invokeTask (zone.js:420)

Please let me know if you need any additional information. Thank you for your great work!

[ghost]

Changing the baseSiteUrl did the trick @koltyakov . I always used just the localhost:8080 and it worked well for single requests. I assumed that since we already specify the sharepoint site url when starting the proxy, all subsequent requests will be based off of that url. Thank you for the great work.

[koltyakov]

Oh, ok. Just wanted to be sure that batches are not misused.

environment.baseSiteUrl = 'http://localhost:8080/sites/goalsdev/2018' // local development

Would be correct for sure.

Proxy resolves / as siteUrl from settings in ordinary requests. But in multipart bodies we should be more strict. And I always recommend using same paths structure.

That’s why this import { loadPageContext } from 'sp-rest-proxy/dist/utils/env'; helper was created. The helper experts that WebpackDevServer is targeted it’s proxy to sp-proxy as well.