Typo in Repository README

What is it that you would like to propose to add/remove/change?

There is a typo in the code in the repository README, specifically in the “Bring Your Own DNS Provider” section. The proper Name attribute for the AWS Route53 ResourceRecordSet should be:

'ResourceRecordSet': {
    'Name': '_acme-challenge' + '.' + domain_name, # No trailing period.
    # More attributes here...
}

and not:

'ResourceRecordSet': {
    'Name': '_acme-challenge' + '.' + domain_name + '.', # Trailing period is incorrect.
    # More attributes here...
}

(the above is directly from the README).

Why do you want to add/remove/change that?

Using the code verbatim from the README causes the validation step to fail with the ACME service. The trailing period is inserted by Route53 automatically, so it doesn’t need to be handled by the client.

The primary reason to change this is just to ensure that the example provided for creating your own DNS provider is correct and works as intended.

[mmaney]

And lo, it finally came to pass that the example has been rewritten, removing all that obfuscating detail specific to one particular service provider as well as adopting the new-model interface.

[mmaney]

I would suggest replacing a long, probably somewhat annotated copy of an existing dns_provider module with a more abstract skeleton… but one which includes the important details, like not importing a provider-specific library at the module level, and documenting the various places you have to edit to integrate a new provider module into (I guess that’s mostly to get it to work with cli.py, although the sewer-as-lib examples show importing sewer.ThisProviderDns, so anyone who follows that example needs some of this, too).