[enhancement] Stage could take the width & height of it's parent

What

I see you have to pass a width & height value you to the Stage component, I’m wondering if instead we should be using a hook like react-use-measure where the canvas would be able to update and size itself correctly based on it’s parent. This could be a nicer developer experience as it’s something that I imagine, most people will implement themselves anyway.

How

I’m not sure how reactive Konva.Stage is and whether or not you’d have to destroy it to give it new dimensions. https://github.com/konvajs/react-konva/blob/672af98bf814a5fd261652cd5bd25ac864c7b6d9/src/ReactKonvaCore.js#L56 But you could use the hook to call the width and height methods to update?

[lavrton]

Well you already can do something like this just fine:

import useMeasure from 'react-use-measure'

function App() {
  const [ref, bounds] = useMeasure()
  return (
    <div ref={ref}>
      <Stage width={bounds.width> height={bounds.height} />
    </div>
  );
}

[lavrton]

For that use case, I am usually using absolute position for stage, so its size doesn’t affect size of parent, so it doesn’t break flex flow.