question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Restructuring of the augmentation package

See original GitHub issue

🚀 Feature

This would introduce a cleaner interface making it much easier to work on a single thing.

Motivation

I struggled a lot when I first went into the source code of kornia, especially the augmentation and as someone coming from other languages than python it is still weird to see multiple classes per file. Moreover I think files with more than thousand lines might indicate bad style.

Pitch

Reorder files into 2d and 3d subfolders which allows to easily spot, whats supported. Outsource each class into a single file wherever it is possible and makes sense. To not break too much, the external interface of augmentation should not change.

Alternatives

Keep as is.

Additional context

cc @shijianjian


Consider also to contribute to Kornia universe projects 😃

  • Tutorials: our repository containing the tutorials.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
twslcommented, Jan 5, 2022

@shijianjian and I agreed on:

  • one augmentation class per file, unless its a non-random variation that probably just inherits from the random class
  • subfolders based on the parent for mix, geometric, intensity
1reaction
edgarribacommented, Jan 4, 2022

Sounds good to me. I would also consider to separate between what’s core, containers and the actual implementation of the augmentations.

Read more comments on GitHub >

github_iconTop Results From Across the Web

What Is Staff Augmentation? | Toptal
Staff augmentation is the use of outside personnel on a temporary basis to augment the capacity of your organization. There is a wide...
Read more >
Workforce Reshaping Operations Handbook - OPM
reorganization, transfer of function or other workforce shaping. VERA is a valuable tool that helps an agency create placement opportunities for employees ......
Read more >
Kaushal Augmentation & Restructuring Mission of AICTE ...
Kaushal Augmentation & Restructuring Mission of AICTE (#KARMA). 1.1K views Streamed 10 months ago. Media AICTE. Media AICTE.
Read more >
Press Release: IMF Approves Augmentation of Turkey's Stand ...
A major bank restructuring will be implemented, aimed at removing the structural weaknesses highlighted during the recent crisis. It includes ...
Read more >
Army Combat Support Hospitals Converting to New Modular ...
The FH and the augmentation detachments will all operate under the ... Our ability to organize tailorable medical support packages with ease ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found