question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider reducing the number of specs

See original GitHub issue

This may look like a weird request, and it probably is, but have you considered reducing the number of *Spec classes? This will allow the library to be more opinionated in how the tests should be written, which is good IMO.

For instance, StringSpec and FunSpec are almost the same, modulo an extra test call. I think using String.invoke to define tests is a clever hack, but wrapping the string in test is just an concise and much less surprising for the user.

Similar reasoning applies to ShouldSpec. Are the cases defined with should any different from the ones defined with test? Maybe. But is it worth the extra concept in the library?

What do you think?

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:1
  • Comments:32 (27 by maintainers)

github_iconTop GitHub Comments

2reactions
sksamuelcommented, Jul 12, 2016

@superbobry agreed, early deprecation is best. I think in this case though we don’t know if we even want to deprecate yet. Some people are saying have one spec, others (like me) are saying leave it alone as it works and everyone seems to like a different spec.

For me, @helmbold’s last comment is the best approach.

1reaction
helmboldcommented, Jul 12, 2016

I tend to leave it as is, too. I think it would be fine to use StringSpec for all examples and still offer the other styles. If we learn that some specs are rarely used, we could deprecate them later.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Tips to reduce your eyeglass number - Kanda Optical
There is a general misconception that once you have eyeglass numbers, they can never be reduced. They will keep increasing as you age....
Read more >
Did your eyeglasses number decrease and if so How? - Quora
Yes, I do believe in wearing glasses could help to less or decrease your eye sight number. But I'm not sure about in...
Read more >
How to Remove Specs Permanently - Time to Get Rid of Specs
There are multiple things that can be tried to remove specs permanently, ... These tips are not proven methods to reduce the refractive...
Read more >
Normal Eye Power & Its Guideline | Complete Eye Care
Is it possible to reduce eye power? Well, there is no real way of reducing the eye number. One can, however, get rid...
Read more >
How to Get Rid of Glasses or Contact Lenses | Centre For Sight
It is not only about finding the glasses but there are a number of ... eventually helping in reducing the power of your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found