Nesting `When` under `When` in `BehaviorSpec` results in silently ignored tests

As illustrated in the sample project, doing something along the lines of:

class DemoTest : BehaviorSpec({

    Given("given") {
        When("top when") {
            When("bottom when") {
                Then("assertion") {
                    1 shouldBe 2
                }
            }
        }
    }
})

and the isolation mode set to IsolationMode.InstancePerLeaf results in all tests passing without execution.

If the isolation mode is left at the default, the outer When is ignored as not containing any tests/leafs, so also not great.

If I understand correctly, Whens are not supposed to be nested under Whens but it’s something that is very easy to miss when writing or reviewing code, and you end up with silently broken test code.

Is it possible to mitigate this in any way?

Which version of Kotest are you using

5.3.0

[sksamuel]

@Kantis I’ve taken the latest snapshot after merging this, and applied it to one of my projects, and tried the above snippet. The nested When is now correctly highlighted as invalid.

[Kantis]

Awesome! I must’ve done something wrong when building locally then 😄