Issues with # entries to show and page focus.
See original GitHub issueHi,
I implemented your libary but when I started testing with some more data I found the following issues:
- When I set
:ds-show-entries="100"
onDatasetShow
it will automatically focus on the last page. - The same will happen if you leave the default of 10 and switch to 100 using the dropdown or switch from 100 to 50, go to page one and reselect 100.
sidenote: you can also see that when we switch from 100 -> 25 the pagenr 3 stays active. because of this item 50-74 gets rendered. I think this is a bit weird. I think switching the amount of items should always preserve the first item and add the amount needed after that. eg.
- show 100 (showing 201-250)
- switch to 25 (showing 201-225)
I made a codepen/screencast so you can see this issue for yourself: https://codesandbox.io/embed/vue-2-playground-forked-0rgcdo?fontsize=14&hidenavigation=1&theme=dark
https://user-images.githubusercontent.com/9568274/183077655-71ef63a6-d3bc-4b51-8347-d3560b9451ef.mov
Vue @ 2.6.12 -> tried with latest version too but issue still exists vue-dataset @ 1.1.15 -> issue seems to exists from all versions > 1.1.5 (lower versions can not run the code as is.)
Hope you can find a solution for this issue since I really like how this component is made apart from this.
Thanks for your work & time!
Issue Analytics
- State:
- Created a year ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
@kouts that seems to have fixed the issue. Thanks for the quick fix!
The issue with the number of entries should be now fixed in https://github.com/kouts/vue-dataset/tree/v1.1.16 @pieterjandebruyne let me know if that worked for you.