Be `allow_population_by_field_name` / `allow_population_by_field_name` value aware when suggesting field names

class FooBase(BaseModel):
    x: str
    y: str = Schema(..., alias='special')

    class Config:
        alias_generator = str.upper

class SuperFoo(FooBase):
    z: str

SuperFoo(X='field name is now upper case', special='Do not forget about alias in schema', Z='Zebra')

[dmontagu]

(Below, I’m going to refer to the allow_population_by_alias setting as allow_population_by_field_name, the new name of the setting in v1.0, since it actually reflects the semantics and so is less confusing.)

Here’s a proposal:

1. If allow_population_by_field_name is True, always use the field names in the generated signatures (I can justify this choice if necessary, but won’t bother if we’re all on the same page)
2. If allow_population_by_field_name is False and alias_generator is explicitly set, use the inferred field names (which will be aliases if specified in the Field; the same as it works now) in the generated signature, but also add a **kwargs argument to the generated signature to prevent pycharm warnings due to the use of generated aliases if they can’t easily be inferred.
   1. Note: the **kwargs argument should only be added if allow_population_by_field_name is False! Otherwise, you should use the field names.

It seems to me that this 1) shouldn’t be a great deal of work to implement, and 2) addresses most use cases very well (including both @skewty’s and my own)

---

@skewty if you take any issues with the above, could you describe the specific behavior you would like from the plugin? By that, I mean examples of:

1. code that should raise warnings
2. code that should not raise warnings
3. how the configuration options you might have in mind would change the displayed warnings

I think that would make it easier to discuss concretely.

[skewty]

@dmontagu I would be okay with such a compromise and would welcome a release with that implemented 😃

PS: thank you all for all the time and energy that has been put into this plugin.