question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Solid implementation doesn't have aria-hidden attributes

See original GitHub issue

@ryansolid glyph icons should have aria-hidden attribute:

  1. vanilla
  2. react
  3. ivi

I don’t think that it would make any perf difference since you are just cloning subtrees, but it would be better if it produced the same DOM output as other implementations.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
ryansolidcommented, Jun 18, 2019

@luwes I think you ended up here with sinuous as well. The aria-hidden needs to be on each row on the remove icon span.

0reactions
krausestcommented, Jun 23, 2019

@xialvjun Thanks for your reply - done!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Element with aria-hidden has no content in sequential focus ...
This rule checks that elements with an aria-hidden attribute do not contain elements that are part of the sequential focus navigation and focusable....
Read more >
aria-hidden='true' must not be present on the document body
Checks for the presence of the 'aria-hidden=”true”' attribute on the 'body' element of the document and returns a message indicating success or failure....
Read more >
Proposal to include visible aria-hidden objects, at least in ...
JAWS recently asked us to consider exposing all visible aria-hidden objects. If something is truly hidden via CSS it still will not be ......
Read more >
aria-hidden - Accessibility - MDN Web Docs - Mozilla
The aria-hidden attribute can be used to hide non-interactive content from the accessibility API. Adding aria-hidden="true" to an element ...
Read more >
Difference between 'hidden' and 'aria-hidden attributes in HTML
Aria hidden attributes indicate to the user the importance of the content they are reading whether the content should be focused on or...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found