Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Throws on invalid dates

See original GitHub issue

> require('msgpackr').encode(new Date('invalid'))
Uncaught:
RangeError: The number NaN cannot be converted to a BigInt because it is not an integer
    at BigInt (<anonymous>)
    at Packr.pack (.../node_modules/msgpackr/dist/node.cjs:1627:41)
    at pack (.../node_modules/msgpackr/dist/node.cjs:1355:34)
    at Object.Packr.pack.encode (.../node_modules/msgpackr/dist/node.cjs:1101:5)

> require('cbor-x').encode(new Date('invalid'))
<Buffer c1 fb 7f f8 00 00 00 00 00 00>

> require('@msgpack/msgpack').encode(new Date('invalid'))
Uint8Array(15) [
  199, 12, 255, 0, 0, 0,
    0,  0,   0, 0, 0, 0,
    0,  0,   0
]

> require('msgpack-lite').encode(new Date('invalid'))
<Buffer c7 09 0d cb 7f f8 00 00 00 00 00 00>

Issue Analytics

State:
Created 2 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

kriszypcommented, Nov 16, 2021

Yes, a better error message certainly seems appropriate. I can certainly just come up with a invalid date representation. It probably would be reasonable to use the MessagePack timestamp code (-1), with zero length data to represent an invalid date. And would probably use a flag for this since it seems like most users prefer predictable fail-fast behavior. But this is a good suggestion, I will take a look at this.

0reactions

kriszypcommented, Nov 19, 2021

Published in v1.5.1