conditional operator not supported

Great plugin. Thanks for writing. Are conditionals supposed to be supported?

This sample input

const countJumps = (list, index, step) => {
  const value = list.get(index);

  if (value === undefined) return step;

  return countJumps(list.set(index, value + 1), index + value, step + 1);
};

const countJumpsTernary = (list, index, step) => {
  const value = list.get(index);

  return value === undefined
    ? step
    : countJumps(list.set(index, value + 1), index + value, step + 1);
};

Produces this output

const countJumps = (list, index, step) => {
  var _repeat = true;

  var _list, _index, _step;

  while (_repeat) {
    _repeat = false;

    const value = list.get(index);

    if (value === undefined) return step;

    _list = list.set(index, value + 1);
    _index = index + value;
    _step = step + 1;
    list = _list;
    index = _index;
    step = _step;
    _repeat = true;
    continue;
  }
};

const countJumpsTernary = (list, index, step) => {
  const value = list.get(index);

  return value === undefined ? step : countJumps(list.set(index, value + 1), index + value, step + 1);
};

Is this the expected behavior? I’m using a fresh install of babel with "tailcall-optimization" as my only plugin.

[acthp]

This is awesome! Thanks!

I just tested with this:

function fact(n, acc = 1) {
	return n > 1 ? fact(n - 1, n * acc) : acc;
}

and with some nested ternary expressions, which have all worked perfectly.

I notice that if I write it as an arrow function, it doesn’t get converted:

var fact = (n, acc = 1) => n > 1 ? fact(n - 1, n * acc) : acc;

output:

var fact = function fact(n) {
  var acc = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 1;
  return n > 1 ? fact(n - 1, n * acc) : acc;
};

while if I write an arrow function with if/else, it does get converted:

var fact = (n, acc = 1) => {
	if (n > 1) {
		return fact(n - 1, n * acc);
	}
	return acc;
};

output:

var fact = function fact(n) {
	var acc = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 1;
	var _repeat = true;

	var _n, _acc;

	while (_repeat) {
		_repeat = false;

		if (n > 1) {
			_n = n - 1;
			_acc = n * acc;
			n = _n;
			acc = _acc;
			_repeat = true;
			continue;
		}
		return acc;
	}
};

Maybe an ordering issue in the transform?

[krzkaczor]

Okay 1.0.12 is out. Please reopen this issue if it didn’t solve your problems.