Editing a KFService Object leaves unused resources

/kind bug

What steps did you take and what happened: Deploying a KFService of the following format

apiVersion: serving.kubeflow.org/v1alpha1
kind: KFService
metadata:
  labels:
    controller-tools.k8s.io: "1.0"
  name: foo
  namespace: foo-ns
  annotations:
	    foo: bar
spec:
  default:
    custom:
      container:
        args:
        - http
        image: mycr.cr.io/fooimg
        name: ""
        resources:
          limits:
            cpu: 400m
            memory: 500Mi
          requests:
            cpu: 400m
            memory: 500Mi
    minReplicas: 2
    maxReplicas: 2
    serviceAccountName: svcacc

I subsequently ran kubectl edit kfservice foo -n foo-ns, edited resources.limits.cpu and resources.requests.cpu and minReplicas to 0. This resulted in the new AND the previous KNative revisions still being active along with the pods associated with them.

What did you expect to happen: The previous revisions are deleted

Anything else you would like to add: This doesn’t seem like expected behavior - out-of-date revisions without an associated route are kept alive and taking up system resources.

Environment:

• Istio Version: 1.1.3
• Knative Version: 0.7.1
• KFServing Version: 0.1
• Kubernetes version: (use kubectl version): 1.13

[yuzisun]

this is now fixed with https://github.com/knative/serving/releases/tag/v0.9.0.

[k8s-ci-robot]

@ellis-bigelow: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.