Generic naming for ONNX model objects
See original GitHub issue/kind feature
Describe the solution you’d like
Currently in order to turn an ONNX runtime model into a servable, the file must have the name model.onnx
, here. This poses restrictions when multiple models are stored in the same directory, or with the potential extension of a storageUri
that exists as a path over the internet. For example, the models in the ONNX model zoo are not directly servable under the current structure.
It would be good to extend the specification & downloading of ONNX models to have an arbitrary name. Whether this can be specified with another field in the CRD (like Pytorch does with modelClassName
, or via some other mechanism is an open question.
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:8 (6 by maintainers)
Top GitHub Comments
Right that was my thinking, just split the filename off the end and validate it. I’ll raise a PR and see what folks think.
aka here: https://github.com/kubeflow/kfserving/blob/2037e9c6c0e09385852af15236e939bd5f25cf71/pkg/apis/serving/v1alpha2/framework_onnx.go#L40
how about if did path.Base(s.StorageUri) and used that if it ends in .onnx?