Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make MutatingWebhook have object selector by default

See original GitHub issue

/kind feature

Is there any particular reason why the troubleshooting step described in the docs (adding object selector on kfserving pod mutating webhook) is not applied in the default in kubeflow/manifests YAML?

See here for the relevant manfiets: https://github.com/kubeflow/manifests/blob/master/kfserving/kfserving-install/base/webhook.yaml

Issue Analytics

State:
Created 3 years ago
Comments:12 (7 by maintainers)

Top GitHub Comments

1reaction

yuzisuncommented, Apr 23, 2021

@pvaneck Just want to confirm, this should be fixed already with Kubeflow 1.3 right?

0reactions

pvaneckcommented, Apr 24, 2021

@yuzisun Yes, this can be closed. The v0.5.1 release is in the manifests repo currently, and that has the objectSelector.

Top Results From Across the Web

Dynamic Admission Control | Kubernetes

Mutating admission webhooks are invoked first, and can modify objects sent to the API server to enforce custom defaults. After all object ......

Writing a very basic kubernetes mutating admission webhook

Mutating admission webhooks allow you to “modify” a (e.g.) Pod (or any kubernetes resource) request. E.g. you can modify a Pod to use...

Create a Basic Kubernetes Mutating Webhook | Thomas Stringer

For all matched operations, it will first apply the mutating webhooks and then take that resource output and apply that to the validating ......

Use `objectSelector` capability to limit what objects get sent to ...

Use the object selector only if the webhook is opt-in, because end users may skip the admission webhook by setting the labels. Default...

A Simple Kubernetes Admission Webhook - Slack Engineering

Mutating admission webhooks are invoked first, and can modify objects sent to the API server to enforce custom defaults. After all object modifications...