Keyword-only arguments in pipeline function signature break the compilation

/kind bug

What steps did you take and what happened: Pass a pipeline function that has keyword-only arguments, e.g. def pipeline(*, keyword_only_argument: str).

Compiler rises:

TypeError: missing a required argument: 'keyword_only_argument'

What did you expect to happen: Pipeline working just fine, just like for non-keyword-only arguments, e.g. def pipeline(casual_argument: str).

Additional information: Origins in compiler.py due to using FullArgsSpec.args, which doesn’t contain keyword-only arguments:

argspec = inspect.getfullargspec(pipeline_func)
(...)
for arg_name in argspec.args:
  args_list.append(...)

with dsl.Pipeline(pipeline_name) as dsl_pipeline:
  pipeline_func(*args_list)

Environment:

Irrelevant.

[ckadner]

So the FullArgSpec does contain the kwonlyargs, which we could make use of here.

class FullArgSpec(NamedTuple):
    args: List[str]
    varargs: Optional[str]
    varkw: Optional[str]
    defaults: Optional[Tuple[Any, ...]]
    kwonlyargs: List[str]
    kwonlydefaults: Optional[Dict[str, Any]]
    annotations: Dict[str, Any]

But is that really a useful thing to do? Why would you define a dsl.Pipeline function with varargs (*) followed by kwonlyargs? Should your pipeline function not have to know about the arguments by name in order to do something useful with them?

[stale[bot]]

This issue has been automatically closed because it has not had recent activity. Please comment “/reopen” to reopen it.