ComponentStore fails to include filename when pulling by version or tag

Looking at the comments around ComponentStore more closely, I don’t think this is a bug, but rather my misunderstanding of the intended behavior: I’ll need to adjust how I publish my components. The further question about using ComponentStore to load standard components (in a comment below) still stands. Leaving this here to get clarification:

What steps did you take:

• stored a Kubeflow component at https://www.example.com/kubeflow/components/gcp/storage/download_dirs/versions/tags/0.1.0/component.yaml

• configured a ComponentStore:

components = ComponentStore(
    url_search_prefixes=[ "https://www.example.com/kubeflow/components/" ]
)

• fetched a versioned component using:

download_from_gcs_op = components.load_component("gcp/storage/download_dirs", tag="0.1.0")

What happened:

With appropriate debugging, it became apparent this was causing a failure because the ComponentStore is attempting to fetch https://www.example.com/kubeflow/components/gcp/storage/download_dirs/versions/tags/0.1.0 and not https://www.example.com/kubeflow/components/gcp/storage/download_dirs/versions/tags/0.1.0/component.yaml.

What did you expect to happen:

Component to be retrieved from https://www.example.com/kubeflow/components/gcp/storage/download_dirs/versions/tags/0.1.0/component.yaml.

Environment:

KFP SDK version: kfp 1.1.0a1

Anything else you would like to add:

I’m unclear if this is intentional, and tagged components should be stored in files bearing the tag as a filename (and no extension). If not, I could probably do a PR, as the reason for this is pretty clear:

https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/components/_component_store.py#L131

Note that the component_file_name is in an else block, so is only added if digest and tag are not specified.

/kind bug

[jackwhelpton]

It’d still be really handy to have this feature: this is a blocker for us sharing component code directly from GitHub Enterprise… a review of the above PR would be great.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.