[feature] Add primary key to DB tables

Feature Area

/area backend

What feature would you like to see?

That kfp create its database with a primary key (probably here and here, with something like:

DefaultExperimentId string `gorm:"column:DefaultExperimentId; not null; primary key"`

What is the use case or pain point?

Primary keys are required for group replication (high availability) of tables in mysql. Enabling this would enable using more resilient data storage.

Is there a workaround currently?

I don’t know if this is safe, but perhaps I can separately create the database following kfp’s schema (but with a primary key) and then have kfp connect to that existing DB? I’m not sure what the consequences of this would be.

update: This appears to work (application starts without errors, etc). Haven’t stress tested it yet

---

Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.

[chensun]

@Linchin given the two PRs are identical, I’d suggest we give credit to @shayancanonical and merge the PR that was created first. It’s also our responsibility to actively monitor and review PRs from community contributors.

@shayancanonical a small tip to do avoid duplicate effort in the future: while you have “Fixes issue#” in the PR title which can close the issue upon PR merged, only when you have the same text in the PR description or comment section, the open PR will then be linked to the issue, so that those who look at the issue can easily see there’s a proposed fix already.

[Linchin]

I see. I will go ahead and create a PR for this.