question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Don't use `react` and `react-router` as dependencies

See original GitHub issue

It causes redundancies. Also, I am receiving this because of this:

warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/es6/useBeforeUnload.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/es6/useQueries.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/Actions.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/AsyncUtils.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/DOMStateStorage.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/DOMUtils.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/ExecutionEnvironment.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/PathUtils.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createBrowserHistory.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createDOMHistory.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createHashHistory.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createHistory.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createLocation.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/createMemoryHistory.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/deprecate.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/enableBeforeUnload.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/enableQueries.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/index.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/runTransitionHook.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/useBasename.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/useBeforeUnload.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/lib/useQueries.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/umd/history.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/umd/history.min.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/CHANGELOG.md shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/LICENSE.md shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/README.md shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/browser.js shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/package.json shouldn't be copied twice in one bulk copy
warning The case-insensitive file /Users/nick/dev/allvest/node_modules/react-router-sitemap/node_modules/history/node_modules/warning/warning.js shouldn't be copied twice in one bulk copy

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
iduuckcommented, Oct 10, 2017

Though, React should be a devDependency and React-Router should be a peerDependency… am I wrong?

0reactions
i8ramincommented, Dec 12, 2017

Any updates on this?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Why I don't use React-Router - asleepysamurai
React -Router is the most popular routing solution out there for React ... as de-facto dependencies for pretty much any application.
Read more >
javascript - Why should I install libraries A(react-router) and B ...
They have react-router as a direct dependency and they re-export every object from it. So, you DON'T need to explicitly add react-router to ......
Read more >
How React Hooks can replace React Router - LogRocket Blog
If you find yourself using both, it's OK to get rid of React Router since you already have it installed as a dependency...
Read more >
history and react-router should be dependencies rather than ...
I think that peerDependencies would be more appropriate, because we need to be able to require pieces from react-router (e.g. Link ...
Read more >
How to Fix: Can't Resolve React Router Dom (in 10 minutes)
One easy way to check if you have installed a dependency, in VS Code, is to press ctrl + left click on the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found