Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BC released in a minor

See original GitHub issue

Hi, you cut 10.1.0 after updating Angular major and that seems to be a breaking change. You cut 11.0.0 shortly after but for people who have ^10.0.10 they will see 10.1.0 a change which I think should have a corresponding major break. Would it be possible to pull 10.1.0 off NPM so people with ^10.0.10 remain unbroken and they can bump to v11 on their own? Thanks

Issue Analytics

State:
Created 10 months ago
Reactions:1
Comments:13 (4 by maintainers)

Top GitHub Comments

2reactions

bborttcommented, Dec 1, 2022

@kuhnroyal wait what, I thought that didn’t work. I remember the command line returning an error code. anyway, glad that actually worked. I’ll do that too for @mat-datetimepicker/core then: https://www.npmjs.com/package/@mat-datetimepicker/core/v/10.1.0.

and for the records:

I checked out the repository @ v10.0.10
I’ve run npm ci
I’ve bumped the versions, resulting in the following diff (fixed peerDependency for the @mat-datetimepicker/moment adapter):

$ git diff
diff --git a/projects/core/package.json b/projects/core/package.json
index a128b48..455191a 100644
--- a/projects/core/package.json
+++ b/projects/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@mat-datetimepicker/core",
-  "version": "10.0.10",
+  "version": "10.1.1",
   "repository": "https://github.com/kuhnroyal/mat-datetimepicker.git",
   "author": "PL <kuhnroyal@gmail.com>",
   "license": "MIT",
diff --git a/projects/moment/package.json b/projects/moment/package.json
index 1e91e46..9c4e932 100644
--- a/projects/moment/package.json
+++ b/projects/moment/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@mat-datetimepicker/moment",
-  "version": "10.0.10",
+  "version": "10.1.1",
   "repository": "https://github.com/kuhnroyal/mat-datetimepicker.git",
   "author": "PL <kuhnroyal@gmail.com>",
   "license": "MIT",
@@ -10,7 +10,7 @@
     "@angular/core": "^14.0.5",
     "@angular/material": "^14.0.4",
     "@angular/material-moment-adapter": "^14.0.4",
-    "@mat-datetimepicker/core": "^10.0.0"
+    "@mat-datetimepicker/core": "10.1.1"
   },
   "dependencies": {
     "tslib": "^2.4.0"

next, I ran npm run build:lib
and then published the backport/fix release
- npm publish ./dist/core && npm publish ./dist/moment
and because I’m a dumbass and forgot that npmjs.org does not respect SemVer, I had to adjust the latest tags using npm dist-tag add @mat-datetimepicker/core@11.0.0 latest && npm dist-tag add @mat-datetimepicker/moment@11.0.0 latest for the final step

1reaction

kuhnroyalcommented, Dec 1, 2022

Yea the unpublish didn’t work, I tried that myself. But the deprecation seems to have worked, nice job!

Top Results From Across the Web

Minor Child And Liability Waivers: Can Parents Sign Kids ...

In a BC case from 2009, a boy's mother signed an agreement on his behalf, waiving the martial arts centre's responsibility for any...

The Infants Act, Mature Minor Consent and Immunization

In B.C. there is no set age when a child is considered capable to give consent. ... How does "mature minor consent" relate...

Academic Policies - Morrissey College of Arts and Sciences

Advanced placement units may fulfill Core, major, or minor requirements, but generally are not awarded as credit toward graduation. For a full list...

BC minors health records information protection | Gowling WLG

Any release of personal health information of a mature minor will need to be consented to by the mature minor, even if the...

release form - Gov.bc.ca

I hereby release and discharge any right, title or interest that I or the Minor may have in the. Recordings or in any...