Change __TS_CONFIG__ from a global variable to a jest configuration

• Issue It seems silly TS_CONFIG should be a global variable, as the test code does not and should not care about it.

I suggest putting it into a jest configuration key instead e.g.

{
"jest" : {
"ts-jest": {
  "__TS_CONFIG__" : {
   
  },
}

This makes more sense, and will later streamline the process of adding more configurations as discussed in #213

This is however a breaking change, and will need deprecation warnings. I also think it would be prudent to support both ways of doing it for a few versions to make sure everyone is caught up. It will be very easy for the end users to migrate.

[GeeWee]

Interesting. This is definitely something we should fix, but it doesn’t seem like it’s close enough to this issue to be discussed here. I’d love it if you started a new issue with a repo that reproduces the error.

[kulshekhar]

@morajabi Thanks for picking this up 😃

or simply skip globals?

We can’t skip globals. Any non-standard jest configuration has to go in globals. The structure you’ve used looks fine. Although I’d like to split __TS_CONFIG into two distinct keys - tsconfigFile and tsConfig to make it clear. (this would require more changes, though) @GeeWee thoughts?

Sorry, What should I do with transpileIfTypescript function

There are two places that’ll need change to address this - util.ts and transpile-if-ts.ts

What I’d suggest is

• create a function that retrieves the config setting
• place a call to this function in the above two places

This function should:

• currently, work with the present config format but display a warning on the console
• work with the new config format

If you have any more questions at any stage feel free to post them here!