30x performance improvement on target.events filter function

I think you can dramatically improve the speed of the filterFn within the buildTargetObject method by using a date intersect check instead of isSameStart, isAfterStart, isSameEnd and isBeforeEnd.

The relevant code is on line 1006. On an events list of 3000, the current code completes the filter in around 130ms vs the intersect code at around 4ms. I might’ve missed something, but so far in testing it works 100%.

Current code:

var filterFn = function () {
    var isSameStart = target.date.isSame(
        this._clndrStartDateObject,
        'day');
    var isAfterStart = target.date.isAfter(
        this._clndrStartDateObject,
        'day');
    var isSameEnd = target.date.isSame(
        this._clndrEndDateObject,
        'day');
    var isBeforeEnd = target.date.isBefore(
        this._clndrEndDateObject,
        'day');
    return (isSameStart || isAfterStart)
        && (isSameEnd || isBeforeEnd);
};

Improved code:

var targetEndDate = (target.date) ? target.date.clone().endOf("day") : null;
var filterFn = function () {
    return (this._clndrStartDateObject <= targetEndDate
        && target.date <= this._clndrEndDateObject);
};

[kylestetz]

This sounds interesting @alexanderschana — want to put together a PR?

[mikegioia]

@alexalexalex-s Thank you again for your help, this has finally made it’s way into production with #341. I’m going to close this one out.