Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

adapter-api does not support headers inputType

See original GitHub issue

Description

The @laconia/adapter-api package does not support the headers inputType from the ApiGatewayEvent.

Is your feature request related to a problem? Please describe. No, there is a work around with the @laconia/event package.

Describe the solution you’d like [optional] It would also be nice to provide the whole ApiGatewayEvent instead of just a specific inputType or at least a way to receive headers.

Additional context Scanning through #124 they seem partially related.

Issue Analytics

State:
Created 2 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

kirbyjscommented, Nov 9, 2021

Your app function will be called with headers, like this: master/packages/laconia-adapter-api/test/ApiGatewayEventAdapter.spec.js#L60

I noticed this option the other day which was pretty slick! Also didn’t know about the includeInputHeader! 👍🏼 That’s good to know and might look into adding that into the docs! I have an incoming PR that I’ve been working on to improve upon the current types.

I still think it might be a good idea to just allow providing the full APIGatewayEvent to future proof the adapter. But it seems that from you comment that everything is currently supported, so feel free to close this issue 😃

0reactions

ceilforscommented, Nov 10, 2021

That’s great! I’ll close this issue 😃