Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Regression in v4: expect(404) treats status code 404 as an error

See original GitHub issue

Consider the following code snippet:

const supertest = require('supertest');

supertest('http://example.com')
  .get('/path-not-found')
  .expect(404)
  .then(
    ok => console.log('PASS'),
    err => {
      console.error('FAIL', err.stack);
      process.exit(1);
    });

Run it using supertest@3.4.2 to get the expected outcome:

PASS

Run it using supertest@4.0.0 to reproduce the bug:

FAIL Error: Not Found
    at Test.Request.callback (/private/tmp/bug/node_modules/supertest/node_modules/superagent/lib/node/index.js:804:15)
    at IncomingMessage.parser (/private/tmp/bug/node_modules/supertest/node_modules/superagent/lib/node/index.js:1036:18)
    at Stream.emit (events.js:182:13)
    at Unzip.unzip.on (/private/tmp/bug/node_modules/supertest/node_modules/superagent/lib/node/unzip.js:55:12)
    at Unzip.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1094:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Issue Analytics

State:
Created 5 years ago
Reactions:6
Comments:9 (4 by maintainers)

Top GitHub Comments

2reactions

holmcommented, Mar 12, 2019

This was definitely surprising to us. It seems to be listed as a “minor change” int he history, but its not easy to understand what “all error events” mean.

I think this will be very surprising to most users, since there is a very big difference between catching an error and checking for a status.

0reactions

bajtoscommented, Mar 18, 2019

Closing as fixed by #1468