double callback! warning

I noticed I was getting a double callback warning in quite a few of my tests using supertest.

I found the issue was with how I was using expect and end as follows

request(app)
  .get('/something')
  .expect(200, function (res) {
    // some logic
    return false
  })
  .end(done);

Changing that to the following resolved the issue for me

request(app)
  .get('/something')
  .expect(function (res) {
    // some logic
    return false;
  })
  .expect(200, done);

To see the double callback warning, see this example

Note that this is using express 4.4.1 and supertest 0.13.0

[vuesomedev]

Just need to remove the .end() call from the request and handle the returned Promise.

This should be documented, really confusing with co-supertest. https://github.com/avbel/co-supertest/issues/9

[n0m0r3pa1n]

I think I get an error connected with this question. Here is my test:

it 'should login user', ->
    createUser("gmirchev90", "1234")
    request(sails.hooks.http.app)
      .post("/api/login")
      .send({username: "gmirchev90", password: "1234"})
      .end (err, res) ->
        console.log(err);
// I get an exception:
// TypeError: First argument must be a string or Buffer

but if I change it with:

request(sails.hooks.http.app)
      .post("/api/login")
      .send({username: "gmirchev90", password: "1234"})
      .expect(200)

Now everything works. Even if I set a wrong code like 400 I get an exception that I got 200 instead of 400. Is this connected with this issue?