.expect() with custom assertion method always succeeds

it('Should have response, time, code', function(done){
        apis.get('/')
            .expect('Content-Type', /json/)
            .expect(406)
            .expect(function(res){
                return true
                /*
                if(!('responses' in res.body)) return "Missing response key"
                if(!('timed' in res.body)) return "Missing time key"
                if(!('codes' in res.body)) return "Missing code key"*/
            })
            .end(done)
    })

My test is always successful even when returning true from the method - which should fail. My other attempts at tackling these are commented in the code.

[finferflu]

This seems to be still an issue:

const request = require('supertest')
const app = require('../app')
const server = request.agent(app)

describe('GET /', function () {
  it('returns 200', function (done) {
    server
    .get('/')
    .expect(500, done)
  })
})

I wrote the above to intentionally fail the test, however it passes.

However, if I use a promise, it fails as expected:

describe('GET /', function () {
  it('returns 200', function (done) {
    server
    .get('/')
    .expect(500)
    .then(function () {
      done()
    })
    .catch(err => {
      done.fail(err)
    })
  })

Output:

Failures:
1) GET / returns 200
  Message:
    Failed: expected 500 "Internal Server Error", got 200 "OK"

[freak4pc]

PS, throwing an exception does produce the right result.

e.g.

it('Should have response, time, code', function(done){
        apis.get('/')
            .expect('Content-Type', /json/)
            .expect(406)
            .expect(function(res){
                if(!('response' in res.body))   throw new Error("Missing response key")
                if(!('time' in res.body))       throw new Error("Missing time key")
                if(!('code' in res.body))       throw new Error("Missing code key")
            })
            .end(done)
    })