.expect(201) passes when res.status == 400

Sorry to create another ticket out of what may be ignorance but…

describe('POST /', function(){
  it('should pass with good img_uri', function(done){
    request(app)
        .post('/')
        .send({
            img_uri: '/foo.png'
        })
        .expect(201)
        .expect('Content-Type', /json/)
        .expect( { ok: 1 } )
        .end(function(err, res){
            console.log( 'BODY: ' );
            console.log( res.body );
            console.log( res.status );
            console.log( 'res.status == 201: '+ res.status == 201 );
            done()
        })
    })
});

The output (in TAP format):

BODY: 
{ ok: 0, msg: 'Missing parameters: img_uri' }
400
false
ok 1 POST / should pass with good img_uri

This seems to show that either the chained .expect() calls are behaving differently than in the examples, or that I failed to understand how they should work.

TIA Lee

[DjebbZ]

I happen to have the same problem, and found how to solve it simply.

Do as @mfrobben says, expect(SOME_CODE, done) when you don’t need complete access to the error and the response.

When you need complete access to do custom stuff in the end callback, test the error as follows :

.end(function(err, res) {
  if (err) {
    done(err);
  } else {
    // do your stuff here
  }
});

I first tried without an else statement, but I got this error : Error: done() called multiple times.

[eeble]

I was getting this error but it turned out it was because I wasn’t separating my redirect/render code paths properly. I forgot to put a return after the redirect so it ended up redirecting then rendering on the same response object.