Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tests with error return fail with version 3.4.0

See original GitHub issue

When using version 3.4.0 tests that test for backend returning an error (400) fail. Example:

it("Check that backend returns 400 with invalid data", async function() {
    let res = await server
        .post("/api/someurl")
        .send({data: "something invalid"})
        .expect("Content-type", /json/)
        .expect(400);
  });

When using version 3.4.0 this test fails with “Bad request” error even when backend returns correctly 400 status code.

With supertest 3.3.0 code works as expected.

Issue Analytics

State:
Created 5 years ago
Reactions:9
Comments:11 (5 by maintainers)

Top GitHub Comments

14reactions

akirilyukcommented, Jan 16, 2019

Hi, I am also experiencing the same issue!

5reactions

gergaczdcommented, Jan 16, 2019

Hi,

I have the same issue. As far as I checked, the problem probably with superagent version upgrade. It had a major version change. The error thrown from node_modules/superagent/lib/node/index.js:804:15) because the _isResponseOK function only accept status codes as valid between 200 and 300 (node_modules/superagent/lib/request-base.js in row 275).

But I am not familiar with that area.