Fix binding issues
See original GitHub issueCurrently Lagom binds everything in dev mode to 0.0.0.0
, and connects to 127.0.0.1
. But, for example, in the case of the service locator, if something is already bound to 127.0.0.1:8000
, then binding to 0.0.0.0:8000
will succeed, but when something goes to actually connect to it, it will connect to the wrong thing.
Binding to 0.0.0.0
allows more flexibility as it means for example you could run something in a container or vm and allow it to connect to your services. But, it does mean that this problem can go unchecked.
The ideal solution I think is to bind to both 0.0.0.0
and 127.0.0.1
. ::1
would probably also be worthwhile. This can be allowed by having a configurable list of bind addresses. I think it would be fine for this list to be configured build wide - it would be annoying to have to configure it for each service individually.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:20 (15 by maintainers)
Top GitHub Comments
@michaelahlers That’s really great to hear – nice validation that I’m on the right track. 😄 Hopefully I can finish it up tonight and get it merged. :shipit:
@erip, checking out 8190446a80d30723dfba736bfcb9a924aa44e0cc did the trick! Thanks for your work on this. 👍
@TimMoore, #1378 fixes my problem! Requests to the local service gateway work as expected (even with VPN interference).