Remove metricsProvider from conductr-lib
See original GitHub issueLagom 1.3.3
enabled a default metricsProvider
for Lagom scaladsl
(https://github.com/lagom/lagom/pull/637). This caused a collision with the metricsProvider
baked into the thin cake by ConductRApplicationComponents
.
This is a meta issue to track the fix through the several repositories where the changes are required.
- update
conductr-lib
to remove the providedmetricsProvider
. See https://github.com/typesafehub/conductr-lib/issues/145 - release a new
conductr-lib
- bump the version of
conductr-lib
used insbt-conductr
. See https://github.com/typesafehub/sbt-conductr/issues/270 and https://github.com/typesafehub/sbt-conductr/issues/271 - release a new
sbt-conductr
- ~warn users of lagom scala pre-1.3.3 of the maximum version of
sbt-conductr
that’s compatible and provide alternatives: a) manually addmetricsProvider
and other required fields to the cake, (b) upgrade Lagom to 1.3.3+.~ See #774 (final impl is backwards compat) - bump version of
sbt-conductr
on our sample apps (scala only) and remove the workaround fromLoader/Application
in each service. Only https://github.com/lagom/online-auction-scala/pull/47 was required (other samples use lagom’s javadsl which is unaffected) - update docs (recommended
sbt-conductr
version) #843
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:5 (5 by maintainers)
Top Results From Across the Web
No results found
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
We’ll also need to update the version of
sbt-conductr
used in our example apps and remove the workaround that was put in place previously.sbt-conductr
2.3.5 is now ready with this change.We should also update the version of
sbt-conductr
recommended in the Lagom docs.