Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rename anything that is specific to Lagom's dev mode to "LagomDevMode*"

See original GitHub issue

There’s a fair amount of internal API in Lagom that is specific to Lagom’s dev mode, but when reading the source, it’s not immediately clear that this is the case, and this can make things quite confusing for someone trying to understand the Lagom source code. We should make it 100% clear what only exists for dev mode by doing the following:

Ensure all internal Lagom devmode components are in a package call devmode.
Rename the major interfaces to be prefixed with LagomDevMode, eg LagomDevModeServiceRegistry.

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:21 (9 by maintainers)

Top GitHub Comments

2reactions

octonatocommented, Jan 10, 2020

Hi @ralphlaude, yeah. Now it’s a good moment to start.

We need to be careful with #2609. @dwijnand is working on cleaning up the reloadable server.

The ultimate goal is to not have a reloaded server in Lagom, but use the one from Play. So, maybe to avoid conflicts you can leave this class untouched.

2reactions

octonatocommented, Jul 17, 2019

@ihostage, I think the main idea of having it prefixed with Lagom is not to indicate that you are in Lagom code base, but because it’s the name of the thing. That’s about Lagom’s Dev Mode infrastructure code.

But I’m ok in removing it. Only DevMode is also fine. Let’s see what others think about it.

👍 for moving devmode package up.