Shutdown reasons not causing a System.exit

Lagom Version (1.2.x / 1.3.x / etc)

Lagom 1.5.0

Expected Behavior

A programatic shutdown of a Lagom process causes a System.exit().

Actual Behavior

If the Reason for CoordinatedShutdown to run is ClusterDowningReason Lagom is taking over the responsibility to invoke System.exit().

This is incomplete since there are other well-known, Akka-provided Reasons that should also trigger a System.exit(). Take for example IncompatibleConfigurationDetected. In this case, the Lagom process would not die.

BONUS POINTS: ClusterDowningReason is reused in edge cases that should use a more specific Reason. For example joinSeedNodesUnsuccesful is a case where a timeout triggers a shutdown because no seed node could be contacted. In that case, the current implementation will work because joinSeedNodesUnsuccesful reuses ClusterDowningReason but if/when the reason is improved to, for example, JoiningSeedNodesUnsuccessfulReason then Lagom will have to follow and react to it.

[marcospereira]

Should this be part of 1.6.x release since we have other issues to better integrate coordinated shutdown?

[ignasi35]

@ignasi35, haven’t you already added this? https://github.com/lagom/lagom/blob/master/cluster/core/src/main/scala/com/lightbend/lagom/internal/cluster/JoinClusterImpl.scala#L86-L90

I sure did.