Dottydoc crashes when upgrading liqp to 0.7.2

Dottydoc currently uses liqp 0.6.7, when upgrading to 0.7.2 (see branch https://github.com/dotty-staging/dotty/commits/upgrade/liqp-0.7.2) and running genDocs we get:

java.lang.ArrayIndexOutOfBoundsException: 1
        at scala.collection.mutable.WrappedArray$ofRef.apply(WrappedArray.scala:130)
        at dotty.tools.dottydoc.staticsite.tags$RenderTitle.render(tags.scala:189)
        at dotty.tools.dottydoc.staticsite.tags$RenderTitle.render(tags.scala:166)
        at liqp.nodes.TagNode.render(TagNode.java:32)
        at liqp.tags.For.renderArray(For.java:112)
        at liqp.tags.For.render(For.java:56)
        at liqp.nodes.TagNode.render(TagNode.java:32)
        at liqp.nodes.BlockNode.render(BlockNode.java:38)
        at liqp.Template$1.call(Template.java:266)
        ... 5 more

The crash happens here: https://github.com/lampepfl/dotty/blob/517ba8cbd7c4c0cd5058a4dd1bdfce2c0fe441cf/doc-tool/src/dotty/tools/dottydoc/staticsite/tags.scala#L189 maybe @felixmulder can give some context on what this does? 😃

[bkiers]

Interesting, I wonder what prompted that changerge. … Apparently it’s to conform with the spec of Liquid.

True: it’s the specs of Liquid that say all parameters to tags are to be treated as a single string. Me implementing them as expressions was wrong.

… and there’s no way to automatically parse that

No need to parse it; evaluating is all that’s needed. I posted a possible workaround how to evaluate the string/expression member.alias: https://github.com/bkiers/Liqp/issues/70

[smarter]

The new scaladoc still uses liqp and it’s still an old version so I’d say yes: https://github.com/lampepfl/dotty/blob/3d85473ee9706b00882f2a1419575b8f0d88487e/project/Build.scala#L1486 /cc @romanowski