writer is never closed

Hi, https://github.com/lanpa/tensorboard-pytorch/blob/master/tensorboardX/record_writer.py self._writer = open(path, 'wb') is never closed

[NilsRethmeier]

@lanpa IMHO this should be fixed asap. This is a very serious issue. Opening 10 SummaryWriter creates close to 3k open files. Even after updating to tensorboardX==1.2.

def test_summary_writer_close():
    # Opening and closing SummaryWriter a lot should not run into
    # OSError: [Errno 24] Too many open files
    passed = True
    try:
        for i in range(10):
            writer = SummaryWriter()
            writer.file_writer.flush()
            writer.file_writer.close()
            writer._record_writer
            del writer
            gc.collect()
    except OSError:
        passed = False

    assert passed
test_summary_writer_close()

lsof | grep ' yourusername ' | awk '{print $NF}' | sort | wc -l

the .close() method has no effect.

[hangg7]

Any updates on this?