[Bug] Disable default order by model key

Bug report

What I did

reading the list operation code

What I expected to happen

code should be correct

What happened

it seem variable not capture as reference

What I’ve already tried to fix it

nothing

Backpack, Laravel, PHP, DB version

not sure

in this file:https://github.com/Laravel-Backpack/CRUD/blob/master/src/app/Http/Controllers/Operations/ListOperation.php in search function:

collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
            if (! isset($item['column'])) {
                return false;
            }

            if ($item['column'] == $this->crud->model->getKeyName()) {
                $hasOrderByPrimaryKey = true;

                return false;
            }
        });

i think variable $hasOrderByPrimaryKey should pass as reference &$hasOrderByPrimaryKey to work at $hasOrderByPrimaryKey = true; command.

Btw, is there anyway to disable order by?

[phammanh029]

@promatik i think it works now. Thanks.

Can you please give us an example why you’d want to remove the default ordering by model primary key? I don’t remember now. I will update latter on.

[promatik]

@phammanh029 regarding your question (disable default order by ID) that PR doesn’t solve it.

Can you please give us an example why you’d want to remove the default ordering by model primary key? I’m finding it difficult to see a situation where it could be useful.

Anyway, if there are use cases, we may add an operation setting for that.

Please let me know 🙌